Just a comment on the code review—whenever I have a disagreement which ultimately I wouldn’t want to hold back the merge on, I’ll both mark it as a nit, and approve the pull request anyway. If they fix it great, if they don’t it doesn’t matter, and if they disagree we can have a long chat about that if we want but it’s not holding up the merge. Generally I’ll do this more with developers I trust not to introduce a new bug fixing the nit, and less with newer less experienced developers.
Just a comment on the code review—whenever I have a disagreement which ultimately I wouldn’t want to hold back the merge on, I’ll both mark it as a
nit, and approve the pull request anyway. If they fix it great, if they don’t it doesn’t matter, and if they disagree we can have a long chat about that if we want but it’s not holding up the merge. Generally I’ll do this more with developers I trust not to introduce a new bug fixing the nit, and less with newer less experienced developers.