Woot, I’ve committed and submitted my first code change to the LW codebase, a proposed fix for Issue 200, learning some novice GitHub and git skills in the process.
Since what prompted me to take this step was to improve the Anti-Kibitzer script, I think my next learning opportunity is going to be a closer integration of the AK within the main LW code base, maybe controlled by a user preference.
Turned out to be almost anti-climactically easy. I couldn’t sleep and returned to the computer to pass some time, started to look into how it would have to be done, and it turned out to be very nearly trivial so I went ahead.
Implementation details: I’ve added a check box to the Preferences page, checked by default, under a “Kibitz options” section, with a label saying “Show commenter names and scores by default”. I plan to add a link to either a new comment on the old Anti-Kibitz top level post, or first write a new top level post and link to that, to serve as end user documentation.
Any suggestions for improvement while I can still make changes at lowest cost?
I’ll wait until tomorrow to commit and submit it for approval by Tricycle, because I don’t trust myself to write bug-free code, even if it looks trivial, at 3am. Especially without having written any unit tests (I’ll have to look closer into what tests there already are before I start writing new ones).
Woot, I’ve committed and submitted my first code change to the LW codebase, a proposed fix for Issue 200, learning some novice GitHub and git skills in the process.
Since what prompted me to take this step was to improve the Anti-Kibitzer script, I think my next learning opportunity is going to be a closer integration of the AK within the main LW code base, maybe controlled by a user preference.
Repo at http://github.com/Morendil/lesswrong
Integral anti-kibitz? That sounds great!
Turned out to be almost anti-climactically easy. I couldn’t sleep and returned to the computer to pass some time, started to look into how it would have to be done, and it turned out to be very nearly trivial so I went ahead.
Implementation details: I’ve added a check box to the Preferences page, checked by default, under a “Kibitz options” section, with a label saying “Show commenter names and scores by default”. I plan to add a link to either a new comment on the old Anti-Kibitz top level post, or first write a new top level post and link to that, to serve as end user documentation.
Any suggestions for improvement while I can still make changes at lowest cost?
I’ll wait until tomorrow to commit and submit it for approval by Tricycle, because I don’t trust myself to write bug-free code, even if it looks trivial, at 3am. Especially without having written any unit tests (I’ll have to look closer into what tests there already are before I start writing new ones).